Skip to content

Reset zoomscale to 1 in Fabric RCTScrollViewComponentView#54668

Closed
johankasperi wants to merge 1 commit into
react:mainfrom
johankasperi:fabric-zoomscale-reset-ios
Closed

Reset zoomscale to 1 in Fabric RCTScrollViewComponentView#54668
johankasperi wants to merge 1 commit into
react:mainfrom
johankasperi:fabric-zoomscale-reset-ios

Conversation

@johankasperi

@johankasperi johankasperi commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

Summary:

Fixes #48772 and expo/expo#39984

Resets the UIScrollView zoomScale to 1 before recycling the RCTScrollViewComponentView in Fabric.

Changelog:

[IOS] [FIXED] - Reset zoomScale to 1 before recycling UIScrollView in Fabric

Test Plan:

Try the snack attached in expo/expo#39984 or the steps to reproduce in the same issue.

@meta-cla

meta-cla Bot commented Nov 25, 2025

Copy link
Copy Markdown

Hi @johankasperi!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@johankasperi johankasperi changed the title fix(iOS): reset zoomscale to 1 in Fabric RCTScrollViewComponentView Reset zoomscale to 1 in Fabric RCTScrollViewComponentView Nov 25, 2025
@meta-cla

meta-cla Bot commented Nov 25, 2025

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 25, 2025
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Nov 25, 2025
@johankasperi johankasperi mentioned this pull request Nov 25, 2025
Closed
@johankasperi

johankasperi commented Nov 25, 2025

Copy link
Copy Markdown
Contributor Author

I also think contentInset needs to be reset before recycling #51231 (comment) But I was unable to make it work

@meta-codesync

meta-codesync Bot commented Nov 26, 2025

Copy link
Copy Markdown

@javache has imported this pull request. If you are a Meta employee, you can view this in D87923379.

@meta-codesync meta-codesync Bot closed this in b37023c Nov 26, 2025
@meta-codesync

meta-codesync Bot commented Nov 26, 2025

Copy link
Copy Markdown

@javache merged this pull request in b37023c.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Zooming in ScrollView causes incorrect offset of content

2 participants

@johankasperi @facebook-github-bot